Born 1943 in Cairo, he graduated from the Department of Criticism at the Higher Institute of Dramatic Arts (1965). Worked as a journalist and film critic at Al-Gomyoreya Newspaper (1964). Dean of Arab critics.
Taught Contemporary Cinema Courses at the Department of Graduate Studies at the Institute of Cinema (1991). Has more than 30 books on Egyptian cinema and more than 15 books on its silent history in addition to comprehensive bibliographies.
Published three books on the Arab-Zionist conflict in film and Zionist cinema as well as Cinema in Occupied Territories and more than 10 books on European and American cinema, and four dictionaries for cinema of EU countries, and four magazines about Arab and international cinema.
Assembled film programs in more than 12 festivals, and participated in the juries in more than 15 Egyptian festivals, regionally and internationally. Received the State Award for Excellence in the Arts of the Supreme Council for Culture (2002). First Arab critic to win the gold medal from Cannes Film Festival (2000). Claimed the prize of excellence in the arts (2002) and the Lifetime Achievement Award in cinema writings of Osian Festival of Asian and Arab Cinema (2012).